-
-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: acknowledgement for v3 #2013
chore: acknowledgement for v3 #2013
Conversation
✅ Deploy Preview for shimmering-choux-eb0798 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey there @jonaslagoni ! 👋
Name - Animesh Kumar |
Samir AMZANI / https://github.com/Amzani |
@alequetzalli I bet you know all the docs contributors that should be mentioned in the thank you, please share them in a comment. |
I made this slide for my last talk at EDA Summit where I added all the GH avatars of people I considered contributors. I remember I did search across the whole |
@jonaslagoni I see @fmvilas requested review from me, but it is your PR, so please have a look at last comment from @smoya in general what is your strategy with this one? merge as quick as possible, or keep it open until the end, in case more names pop up? @alequetzalli pingy pongy regarding #2013 (comment) |
@derberg we can keep it open sure, right up until the release. |
Hey @derberg, thank you for pointing this out! To answer your question... I guess it would be all writers working in our Mentorship/GSOD 2023 programs, since they are all writing with only v3 in mind. The following folks should be added then:
|
@alequetzalli no there were no specific updated to Generator docs that Florence had to work on |
Thanks @alequetzalli!
You have been added to the list, please feel free to suggest the name that should be displayed and the link 🙂 |
Ashish Padhy / https://github.com/Shurtu-gal |
please add @alaminthespecial for work on #2004 |
Co-authored-by: Sergio Moya <[email protected]>
@Shurtu-gal and @alaminthespecial you have both been added, feel free to suggest changes to the social links 🙂 |
I think we can merge this PR as release in next week. If any new name pops up, we can always add it last minute or even after release |
Makes sense 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
/rtm |
Description
This PR is to add all who participated in the development of v3 in one way or another - maybe you added your own views on features included in v3, attended meetings, adapted documentation, adapted tooling, i.e. helped in any way to make v3 happen 💪
It will be part of the v3 release blog post in the acknowledgement section: https://v3.asyncapi.com/blog/release-notes-3.0.0#acknowledgements
It would be an impossible task for me to go through all relevant issues, PRs, and meetings to find all of you not to mention for sure miss someone, so I am asking for a bit of help to include your name here.
To get added to the list of users just comment on this PR with a link to where you participated (not ALL times, just a single one) and with what name and link it should be associated with, and that's it 🎉
Initial list
@Fannon, @char0n, @fmvilas, @derberg, @smoya, @damaru-inc, @magicmatatjahu, @jessemenning, @GreenRover, @GeraldLoeffler, @c-pius, @iancooper, @dalelane, @joerg-walter-de, @nictownsend, @lbroudoux, @olamiral, @ivangsa, @buehlefs, @jfallows, @adrianhopebailie, @prdatur, @basickarl, @jjimenezroda, @smarek, @natcl, @whitlockjc, @Souvikns
You have been tagged because you are on the initial list of users added to the acknowledgment section because you participated in the development of v3 in one of the spec issues listed under "Completed" in asyncapi/spec#691. That was the best way I saw to kickstart the list.
I am tagging you here to notify you about it and give you the option to be removed, change the link, or name as you see fit. By default, I am using your GitHub handle and public name 😄